hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4156) Seeking to a negative position should throw an IOE
Date Thu, 15 Nov 2012 01:42:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497692#comment-13497692
] 

Eli Collins commented on HDFS-4156:
-----------------------------------

Nit: "Cannot seek before beginning of file block" might be better written as "Cannot seek
to a negative offset" given that the outputstream is per file not per block. If you agree
I'll make the change.

Otherwise, +1 looks great!
                
> Seeking to a negative position should throw an IOE
> --------------------------------------------------
>
>                 Key: HDFS-4156
>                 URL: https://issues.apache.org/jira/browse/HDFS-4156
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Reisman
>              Labels: newbie
>         Attachments: HDFS-4156-1.patch, HDFS-4156-2.patch, HDFS-4156-3.patch
>
>
> Credit to [~vanzin] for finding this. If you seek() to a position before the start of
the file, the seek() call succeeds, and the following read() call throws an NPE. A more friendly
approach would be to fail the seek() call.
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> at org.apache.hadoop.hdfs.DFSInputStream.readWithStrategy(DFSInputStream.java:670)
> at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:685)
> at java.io.DataInputStream.read(DataInputStream.java:83)
> at fstest.main(fstest.java:12)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message