hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4209) Clean up the addNode/addChild/addChildNoQuotaCheck methods in FSDirectory
Date Mon, 26 Nov 2012 21:22:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504110#comment-13504110
] 

Suresh Srinivas commented on HDFS-4209:
---------------------------------------

Comments:
# Please see HDFS-4228. I would rather use the Path*Exception instead of introducing PathException
here.
# INodeDirect#getParent() no longer needs to throw FileNotFoundException.
# Earlier where FileNotFoundException was thrown now some other exception might be thrown.
This could break existing applications that might be catching FileNotFoundException? Should
we throw FileNotFoundException in INodeDirectory, INodeFileUnderConstruction valueOf method?
We do throw FileNotFoundException when a directory was not found in other methods.
# INodeFile#valueOf() no need to throw PathException

                
> Clean up the addNode/addChild/addChildNoQuotaCheck methods in FSDirectory
> -------------------------------------------------------------------------
>
>                 Key: HDFS-4209
>                 URL: https://issues.apache.org/jira/browse/HDFS-4209
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4209_20121118b.patch, h4209_20121118.patch, h4209_20121119.patch,
h4209_20121121.patch
>
>
> - Returning the same INode back is not useful.  It is better to simply return a boolean
to indicate whether the inode is added.
> - The value of childDiskspace parameter is always UNKNOWN_DISK_SPACE.
> - In most cases, the value of the pos parameter is length - 1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message