hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4188) Add a snapshot id comparator
Date Fri, 16 Nov 2012 00:47:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498481#comment-13498481
] 

Aaron T. Myers commented on HDFS-4188:
--------------------------------------

Patch looks pretty good, thanks for making it.

Perhaps we should add some tests specifically for ReadOnlyList#binarySearch, since it's no
longer just delegating to a library method?
                
> Add a snapshot id comparator
> ----------------------------
>
>                 Key: HDFS-4188
>                 URL: https://issues.apache.org/jira/browse/HDFS-4188
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: Snapshot (HDFS-2802)
>
>         Attachments: h4188_20121113.patch, h4188_20121114.patch
>
>
> The Snapshot class currently has two compareTo methods. The one for comparing IDs is
not implementing the Comparable interface since Java does not allow implementing the same
interface twice with different generic types.  It is better to remove one of the compareTo
methods for avoiding confusion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message