hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4216) Adding symlink should not ignore QuotaExceededException
Date Wed, 21 Nov 2012 05:11:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501705#comment-13501705
] 

Eli Collins commented on HDFS-4216:
-----------------------------------

Two nits, otherwise looks great

- This refers to WebHdfsFileSystem, eg instead of "Test symlink creation that violates namespace
quotas" 
{code}
+  /** Test WebHdfsFileSystem.craeteSymlink(..). */  
+  public void testQuota() throws IOException {
{code}
- I'd replace this
{code}
+      fail();
+    } catch(QuotaExceededException qee) {
+      DistributedFileSystem.LOG.info("GOOD", qee);
+    }
{code}
with something like
{code}
      fail("Created symlink despite quote violation");
    } catch (QuotaExceededException qee) {
      // Expected
    }
{code}


                
> Adding symlink should not ignore QuotaExceededException
> -------------------------------------------------------
>
>                 Key: HDFS-4216
>                 URL: https://issues.apache.org/jira/browse/HDFS-4216
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4216_20121120.patch, HDFS-4216-1.patch
>
>
> FSDirectory.unprotectedSymlink(..) catches IOException and ignores it.  As a consequence
it ignores QuotaExceededException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message