hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4177) Add a snapshot parameter to INodeDirectory.getChildrenList()
Date Tue, 13 Nov 2012 00:21:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495781#comment-13495781
] 

Suresh Srinivas commented on HDFS-4177:
---------------------------------------

Comments:
# INodeDirectory#getChildrenList javadoc need to be updated to include snapshot information.
This comment can be handled when you handle the TODO item in that part of the code.
# getLatestSnapshot() and getPathSnapshot() are very similar names with very close implementation
and is quite confusing. Also the javadoc "the latest snapshot has been taken in the path"
does not read right. Also what is "the snapshot specified in the path"?
# FSPermissionChecker - a line > 80 chars
# Please add some tests for ReadOnlyList functionality. Also please create a jira for adding
tests when getChildrenList() TODO is complete for the real functionality.

                
> Add a snapshot parameter to INodeDirectory.getChildrenList()
> ------------------------------------------------------------
>
>                 Key: HDFS-4177
>                 URL: https://issues.apache.org/jira/browse/HDFS-4177
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4177_20121112.patch
>
>
> With the snapshot features, the children list of directories can be different in snapshots
and the current view.  The snapshot information is required to select the children list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message