hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4143) Change INodeFile.blocks to private
Date Fri, 02 Nov 2012 21:22:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489761#comment-13489761

Tsz Wo (Nicholas), SZE commented on HDFS-4143:

> Inode.java - why make toString() final?

I might be wrong - I think some code depends on the string format so that subclasses cannot
override it.  Let me double check.
> Change INodeFile.blocks to private
> ----------------------------------
>                 Key: HDFS-4143
>                 URL: https://issues.apache.org/jira/browse/HDFS-4143
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4143_20121101.patch
> INodeFile.blocks is currently package private.  It is accessed directly in quite many
case.  It is better to change it to package private and access via setter and getter methods.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message