hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4148) Disallow write/modify operations on files and directories in a snapshot
Date Thu, 15 Nov 2012 23:21:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498437#comment-13498437

Aaron T. Myers commented on HDFS-4148:

I actually prefer the name getMutableX variant. I think long method names should not be used
as substitute for javadoc which describes functionality. My preference is to either stick
to getXYZMutable or getMutableXYZ.
Also getXYZNotRO or getXYZNonRO is also okay.

I still prefer a completely separate check. There's no long method name at all if we're not
conflating "getX" with "checkXNonRO". They're really separate operations, so separating the
methods makes sense to me.

That said, if we really want to stick with the getters also doing the checks then I'm fine
with the "getXNonRO" variant. Going with something like "getNonROX" or "getMutableX" makes
it seem like the method "gets a mutable X" instead of "get X and throw an error if its not
>  Disallow write/modify operations on files and directories in a snapshot
> ------------------------------------------------------------------------
>                 Key: HDFS-4148
>                 URL: https://issues.apache.org/jira/browse/HDFS-4148
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: Snapshot (HDFS-2802)
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>             Fix For: Snapshot (HDFS-2802)
>         Attachments: HDFS-4148.patch, HDFS-4148.patch, HDFS-4148.patch, HDFS-4148.patch,
> disallow modification on RO snapshots, including create, append, setReplication/Permission/Owner,
rename, delete, makedir, setQuota/Time, createSymlink. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message