hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4132) when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory
Date Thu, 01 Nov 2012 00:35:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488379#comment-13488379
] 

Hadoop QA commented on HDFS-4132:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12551642/HDFS-4132.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3436//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3436//console

This message is automatically generated.
                
> when libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory 
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-4132
>                 URL: https://issues.apache.org/jira/browse/HDFS-4132
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-4132.001.patch
>
>
> When libwebhdfs is not enabled, nativeMiniDfsClient frees uninitialized memory.
> Details: jconfStr is declared uninitialized...
> {code}
> struct NativeMiniDfsCluster* nmdCreate(struct NativeMiniDfsConf *conf)
> {
>     struct NativeMiniDfsCluster* cl = NULL;
>     jobject bld = NULL, bld2 = NULL, cobj = NULL;
>     jvalue  val;
>     JNIEnv *env = getJNIEnv();
>     jthrowable jthr;
>     jstring jconfStr;
> {code}
> and only initialized later if conf->webhdfsEnabled:
> {code}
>     ...
>     if (conf->webhdfsEnabled) {
>         jthr = newJavaStr(env, DFS_WEBHDFS_ENABLED_KEY, &jconfStr);
>         if (jthr) {
>             printExceptionAndFree(env, jthr, PRINT_EXC_ALL,
>     ...
> {code}
> Then we try to free this uninitialized memory at the end, usually resulting in a crash.
> {code}
>     (*env)->DeleteLocalRef(env, jconfStr);
>     return cl;
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message