hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4209) Clean up FSDirectory and INode
Date Tue, 20 Nov 2012 22:20:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501547#comment-13501547
] 

Tsz Wo (Nicholas), SZE commented on HDFS-4209:
----------------------------------------------

> addToParentForImageLoading - I would use the same convention as currently exists unprotectedAddToParent().
...

Unlike other unprotected methods, this method is only used in image loading but not rpc call.
 (e.g. unprotectedSetPermission is used by both image loading and setPermission RPC call.)
 So I call it addToParentForImageLoading.  A better way is to move it to FSImageFormat.

I split this part to HDFS-4215.
                
> Clean up FSDirectory and INode
> ------------------------------
>
>                 Key: HDFS-4209
>                 URL: https://issues.apache.org/jira/browse/HDFS-4209
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4209_20121118b.patch, h4209_20121118.patch, h4209_20121119.patch
>
>
> - FSDirectory.addToParent(..) is only used by image loading so that synchronization,
modification time update and space count update are not needed.
> - There are multiple places checking whether an inode is file by checking !isDirectory()
&& !isSymlink().  Let's add isFile() to INode.
> - In the addNode/addChild/addChildNoQuotaCheck methods, returning the same INode back
is not useful.  It is better to simply return a boolean to indicate whether the inode is added.
 Also, the value of childDiskspace parameter is always UNKNOWN_DISK_SPACE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message