hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4196) Support renaming of snapshots
Date Fri, 16 Nov 2012 07:16:12 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jing Zhao updated HDFS-4196:
----------------------------

    Attachment: HDFS-4196.003.patch

Thanks for the comments! Uploaded a new patch mainly addressing Aaron's comments: 
1. Add javadoc description explaining exception for renameSnapshot and createSnapshot in SnapshotManager.

2. Reorder parameters in INodeDirectorySnapshottable#renameSnapshot.

3. Use HdfsConstants.DOT_SNAPSHOT_DIR to replace .snapshot

4. For rename, seems we only need to acquire FSNamesystem's write lock (FSDirectory#getINode
already gets the read lock of FSDirectory). Also add some comments in SnapshotManager.

5. Use SnapshotException to replace IOException in INodeDirectorySnapshottable#renameSnapshot.

6. Make TestSnapshotRename#testSnapshotRename more readable..

Besides, will address the name checking problem in a later jira.


                
> Support renaming of snapshots
> -----------------------------
>
>                 Key: HDFS-4196
>                 URL: https://issues.apache.org/jira/browse/HDFS-4196
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4196.001.patch, HDFS-4196.002.patch, HDFS-4196.003.patch
>
>
> Add the functionality of renaming an existing snapshot with a given new name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message