hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-4209) Clean up FSDirectory and INode
Date Mon, 19 Nov 2012 01:06:58 GMT
Tsz Wo (Nicholas), SZE created HDFS-4209:

             Summary: Clean up FSDirectory and INode
                 Key: HDFS-4209
                 URL: https://issues.apache.org/jira/browse/HDFS-4209
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: name-node
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Tsz Wo (Nicholas), SZE
            Priority: Minor
         Attachments: h4209_20121118.patch

- FSDirectory.addToParent(..) is only used by image loading so that synchronization, modification
time update and space count update are not needed.

- There are multiple places checking whether an inode is file by checking !isDirectory() &&
!isSymlink().  Let's add isFile() to INode.

- The addNode/addChild/addChildNoQuotaCheck methods returning the same INode back is not useful.
 It is better to simply return a boolean to indicate whether the inode is added.  Also, the
childDiskspace parameter is always unknown.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message