hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4175) Extend existing TestSnapshot to support more complicated directory structure and more modifications on current files/direcotories
Date Mon, 19 Nov 2012 01:18:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499982#comment-13499982
] 

Suresh Srinivas commented on HDFS-4175:
---------------------------------------

This is one complicated test to review. Took me a while. Some comments:
# The TestDirectoryTree and TestDirectoryNode need lot more javadocs to make it easy to understand.
# Move TestDirectoryNode as an inner class of TestDirectoryTree.
# It is better to rename TestDirectoryTree#numOfLevel as height?
# The change in SnapshotTestHelper.java is no longer needed it looks like.
# TestSnapshotDeletion has test for snapshottable directories. Should it be moved to TestSnapshot?
                
> Extend existing TestSnapshot to support more complicated directory structure and more
modifications on current files/direcotories
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4175
>                 URL: https://issues.apache.org/jira/browse/HDFS-4175
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4175-snapshot-test.002.patch, snapshot-test.001.patch
>
>
> Currently the TestSnapshot only uses a static simple directory structure for testing
snapshot functionalities. We need to test snapshot under more complicated directory structures.

> Also the current TestSnapshot only compares snapshots before/after three types of modifications:
file creation, deletion, and appending. We need to test snapshots for more file modifications,
including file permission change, replication factor change, owner/group change, and sub-directory
creation/deletion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message