hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4143) Change INodeFile.blocks to private
Date Fri, 02 Nov 2012 03:38:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489229#comment-13489229
] 

Suresh Srinivas commented on HDFS-4143:
---------------------------------------

Inode.java - why make toString() final?

Other than this the patch looks good. +1 with Jenkins +1.
                
> Change INodeFile.blocks to private
> ----------------------------------
>
>                 Key: HDFS-4143
>                 URL: https://issues.apache.org/jira/browse/HDFS-4143
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4143_20121101.patch
>
>
> INodeFile.blocks is currently package private.  It is accessed directly in quite many
case.  It is better to change it to package private and access via setter and getter methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message