hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4213) When the client calls hsync, allows the client to update the file length in the NameNode
Date Wed, 28 Nov 2012 18:32:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505752#comment-13505752
] 

Aaron T. Myers commented on HDFS-4213:
--------------------------------------

Thanks, Jing. The latest patch looks a lot better to me. I confirmed that it now passes TestHFlush
correctly.

One final little issue: I recommend you rename the enum "SyncFlags" to "SyncFlag" (no "s").
This is more inline with the similar CreateFlag enum.

Other than that the patch looks good to me. I agree we can move stuff to Common as I described
as the need arises later.
                
> When the client calls hsync, allows the client to update the file length in the NameNode
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-4213
>                 URL: https://issues.apache.org/jira/browse/HDFS-4213
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4213.001.patch, HDFS-4213.002.patch, HDFS-4213.003.patch, HDFS-4213.004.patch,
HDFS-4213.005.patch, HDFS-4213.006.patch, HDFS-4213.007.patch
>
>
> As per discussion in HDFS-3960 and HDFS-2802, when clients that need strong consistency
update the file length at the NameNode, a special sync/flush is required for getting the length
of the being written files when snapshots are taken for these files. This jira implements
this sync-with-updating-length by 1) calling ClientProtocol#fsync(), and 2) adding a new field
to ClientProtocol#fsync() to indicate the length information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message