hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4206) Change the fields in INode and its subclasses to private
Date Sun, 18 Nov 2012 21:54:57 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499919#comment-13499919
] 

Suresh Srinivas commented on HDFS-4206:
---------------------------------------

+1 for the change. The code looks much cleaner now.
                
> Change the fields in INode and its subclasses to private
> --------------------------------------------------------
>
>                 Key: HDFS-4206
>                 URL: https://issues.apache.org/jira/browse/HDFS-4206
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4206_20121116b.patch, h4206_20121116.patch
>
>
> The fields in INode and its subclasses are sometimes directly accessed and modified by
other code.  It is better to change them to private and use getters/setters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message