hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4199) Provide test for HdfsVolumeId
Date Mon, 19 Nov 2012 20:21:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500615#comment-13500615
] 

Robert Joseph Evans commented on HDFS-4199:
-------------------------------------------

The changes look fairly simple and straight forward.  They also match the code.  However,
I am just a bit concerned that we are testing/locking in functionality that is arguably wrong.

We are testing that new HdfsVolumeId(A, false).equals(new HdfsVolumeId(A, true)).  If you
look at how the code actually works it starts out by creating a bunch of invalid ids with
null for the id.  Then it goes off and replaces them with valid IDs once it finds them.  I
personally don't think that a valid volume ID should ever be equal to an invalid one.  I added
Andrew who originally wrote this code to see if he can take a look at it and tell us if this
is expected behavior on not.
                
> Provide test for HdfsVolumeId
> -----------------------------
>
>                 Key: HDFS-4199
>                 URL: https://issues.apache.org/jira/browse/HDFS-4199
>             Project: Hadoop HDFS
>          Issue Type: Test
>    Affects Versions: 2.0.2-alpha
>            Reporter: Ivan A. Veselovsky
>            Assignee: Ivan A. Veselovsky
>            Priority: Minor
>         Attachments: HADOOP-9053.patch, HDFS-4199--b.patch, HDFS-4199.patch
>
>
> Provide test for HdfsVolumeId to improve the code coverage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message