hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4196) Support renaming of snapshots
Date Fri, 16 Nov 2012 22:17:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499194#comment-13499194
] 

Aaron T. Myers commented on HDFS-4196:
--------------------------------------

The updated patch looks pretty good to me, except that I think we can remove the synchronization
from SnapshotManager#createSnapshot as well, and remove the FSDir locking from FSNS#createSnapshot.
This also implies that we should probably move the comment you put in SnapshotManager#renameSnapshot
up to the class comment of SnapshotManager. I realize that that's unrelated to this particular
change, but we might as well make it here I think.

In general I think the locking structure for snapshot operations should be:

# Lock the FSNS lock in FSNS before calling into SnapshotManager methods.
# Rely on the FSDir's internal locking for actual INode* modifications made by SnapshotManager.

How does this sound?
                
> Support renaming of snapshots
> -----------------------------
>
>                 Key: HDFS-4196
>                 URL: https://issues.apache.org/jira/browse/HDFS-4196
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, name-node
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4196.001.patch, HDFS-4196.002.patch, HDFS-4196.003.patch
>
>
> Add the functionality of renaming an existing snapshot with a given new name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message