hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raja Aluri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4163) HDFS distribution build fails on Windows
Date Fri, 09 Nov 2012 21:59:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494343#comment-13494343
] 

Raja Aluri commented on HDFS-4163:
----------------------------------

+1 Looks Good To me.
One nit.
Please consider using os.path.abspath(os.path.join()) instead of normpath for cross platform
sake. But it's just for code readability sake. I will leave it to you.
{code}
>>> os.path.abspath(".")
'/Users/raja/work/repos/'
>>> os.path.abspath("../")
'/Users/raja/work'
>>> os.path.normpath("../../")
'../..'
>>> os.path.normpath("..")
'..'
>>> os.path.normpath("..")

{code}
                
> HDFS distribution build fails on Windows
> ----------------------------------------
>
>                 Key: HDFS-4163
>                 URL: https://issues.apache.org/jira/browse/HDFS-4163
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: build
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HDFS-4163-branch-trunk-win.patch
>
>
> Distribution build relies on sh scripts that do not work on Windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message