hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4149) Complete the code for disallowSnapshot
Date Sun, 04 Nov 2012 23:40:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490329#comment-13490329
] 

Suresh Srinivas commented on HDFS-4149:
---------------------------------------

Comments:
# DistributedFileSystem.java - change the param name to createSnapshot from snapshotRoot to
root. I suggest making similar change in the FileSystem.java as well.
# SnapshotManager#resetSnapshottable - Along with "The directory has snapshot(s)...", please
also add, "Please redo the operation after removing all the snapshots."
# InodeDirectorySnapshottable
#* Member variable #snapshots - if there is a specific order in which snapshots are stored
(that decreasing order creation time), please add it in the javadoc for this member variable.
#* "Number of snapshots is allowed." should be "Number of snapshots allowed."
#* It may be good to add javadoc to the InodeDirectorySnapshottable class to say it is synchronized
external by {@link SnapshotManager}
#* Make getNumSnapshots() package private so that only SnapshotManager can use it with proper
synchronization?
#* Javadoc for #getSnapshotRoot() to describe what is snapshot root would help. Also change
variable name "name" to snapshotName.

                
> Complete the code for disallowSnapshot
> --------------------------------------
>
>                 Key: HDFS-4149
>                 URL: https://issues.apache.org/jira/browse/HDFS-4149
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4149_20121104.patch
>
>
> Implement the disallowSnapshot(..) in FSNamesystem and add a resetSnapshottable(..) to
SnapshotManager.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message