hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4209) Clean up the addNode/addChild/addChildNoQuotaCheck methods in FSDirectory
Date Tue, 20 Nov 2012 22:54:58 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsz Wo (Nicholas), SZE updated HDFS-4209:
-----------------------------------------

    Description: 
In the addNode/addChild/addChildNoQuotaCheck methods, returning the same INode back is not
useful.  It is better to simply return a boolean to indicate whether the inode is added.

Also, the value of childDiskspace parameter is always UNKNOWN_DISK_SPACE.  In most cases,
the value of the pos parameter is length - 1.

  was:
- FSDirectory.addToParent(..) is only used by image loading so that synchronization, modification
time update and space count update are not needed.

- There are multiple places checking whether an inode is file by checking !isDirectory() &&
!isSymlink().  Let's add isFile() to INode.

- In the addNode/addChild/addChildNoQuotaCheck methods, returning the same INode back is not
useful.  It is better to simply return a boolean to indicate whether the inode is added. 
Also, the value of childDiskspace parameter is always UNKNOWN_DISK_SPACE.

        Summary: Clean up the addNode/addChild/addChildNoQuotaCheck methods in FSDirectory
 (was: Clean up FSDirectory and INode)

Revised Summary and Description.
                
> Clean up the addNode/addChild/addChildNoQuotaCheck methods in FSDirectory
> -------------------------------------------------------------------------
>
>                 Key: HDFS-4209
>                 URL: https://issues.apache.org/jira/browse/HDFS-4209
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4209_20121118b.patch, h4209_20121118.patch, h4209_20121119.patch
>
>
> In the addNode/addChild/addChildNoQuotaCheck methods, returning the same INode back is
not useful.  It is better to simply return a boolean to indicate whether the inode is added.
> Also, the value of childDiskspace parameter is always UNKNOWN_DISK_SPACE.  In most cases,
the value of the pos parameter is length - 1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message