Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 18 Oct 2012 23:04:03 +0000 (UTC)
From: "Jing Zhao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <814643840.66448.1350601443345.JavaMail.jiratomcat@arcas>
In-Reply-To: <930381584.49855.1350362823693.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-4062) In branch-1,
 FSNameSystem#invalidateWorkForOneNode and
 FSNameSystem#computeReplicationWorkForBlock should print logs outside of
 the namesystem lock
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479455#comment-13479455 ] 

Jing Zhao commented on HDFS-4062:
---------------------------------

test-patch output:
-1 overall.  
    +1 @author.  The patch does not contain any @author tags.
    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.
    +1 javadoc.  The javadoc tool did not generate any warning messages.
    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
    -1 findbugs.  The patch appears to introduce 222 new Findbugs (version 2.0.1) warnings.
                
> In branch-1, FSNameSystem#invalidateWorkForOneNode and FSNameSystem#computeReplicationWorkForBlock should print logs outside of the namesystem lock
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4062
>                 URL: https://issues.apache.org/jira/browse/HDFS-4062
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4062.b1.001.patch
>
>
> Similar to HDFS-4052 for trunk, both FSNameSystem#invalidateWorkForOneNode and FSNameSystem#computeReplicationWorkForBlock in branch-1 should print long log info level information outside of the namesystem lock. We create this separate jira since the description and code is different for 1.x.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira