Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 18 Oct 2012 03:40:03 +0000 (UTC)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <701813561.61897.1350531603669.JavaMail.jiratomcat@arcas>
In-Reply-To: <2007488008.60199.1350506764315.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-4072) When deleting a file, it would be
 better to also remove corresponding block records from
 BlockManager#pendingReplications
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478629#comment-13478629 ] 

Eli Collins commented on HDFS-4072:
-----------------------------------

Adding pendingReplications.remove(block) to removeBlock means we're just decrementing the replica count by 1 right? Seems like we should add this call to removeStoredBlock instead so we decrement each time a DN reports that the block has been deleted, and we eventually drop the replica count to 0 and removed the entry from PendingReplications. I think updating the test to corrupt two replicas would catch this.
                
> When deleting a file, it would be better to also remove corresponding block records from BlockManager#pendingReplications
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4072
>                 URL: https://issues.apache.org/jira/browse/HDFS-4072
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4072.trunk.001.patch, HDFS-4072.trunk.002.patch, TestPendingAndDelete.java
>
>
> Currently when deleting a file, blockManager does not remove records that are corresponding to the file's blocks from pendingRelications. These records can only be removed after timeout (5~10 min).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira