Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24877D517 for ; Mon, 22 Oct 2012 06:52:15 +0000 (UTC) Received: (qmail 17369 invoked by uid 500); 22 Oct 2012 06:52:14 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 16780 invoked by uid 500); 22 Oct 2012 06:52:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 16761 invoked by uid 99); 22 Oct 2012 06:52:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2012 06:52:13 +0000 Date: Mon, 22 Oct 2012 06:52:13 +0000 (UTC) From: "Uma Maheswara Rao G (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <647448732.8728.1350888733305.JavaMail.jiratomcat@arcas> In-Reply-To: <2126666023.8093.1350865092455.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HDFS-4099) Clean up replication code and add more javadoc MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481218#comment-13481218 ] Uma Maheswara Rao G commented on HDFS-4099: ------------------------------------------- Thanks Nicholas, for cleaning up. +1 from me too, for the patch. > Clean up replication code and add more javadoc > ---------------------------------------------- > > Key: HDFS-4099 > URL: https://issues.apache.org/jira/browse/HDFS-4099 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: h4099_20121021.patch > > > - FSNamesystem.checkReplicationFactor(..) should be combined with BlockManager.checkReplication(..). > - Add javadoc to the replication related method in BlockManager. > - Also clean up those methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira