Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 30 Oct 2012 04:50:12 +0000 (UTC)
From: "Kan Zhang (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <626510346.42767.1351572612837.JavaMail.jiratomcat@arcas>
In-Reply-To: <783342637.47775.1350336663170.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-4056) Always start the NN's SecretManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486643#comment-13486643 ] 

Kan Zhang commented on HDFS-4056:
---------------------------------

bq. You need a technical reason for the -1. I agree with Daryn that the code will be easier if we always have the secret manager. The overhead is minimal in all cases, especially if you don't use tokens.

To start a daemon thread when you know you won't be using it (or worse, tokens are issued but never used) is not only sloppy coding, but also confusing and may lead to more bugs. In the parent JIRA, we have agreed on trying an approach where SIMPLE is kept as is and SASL PLAIN is added for testing. See HADOOP-8779 for more discussions. If we go with that approach, there is no need for this patch. And we should also revert HADOOP-8783 and HADOOP-8784.
                
> Always start the NN's SecretManager
> -----------------------------------
>
>                 Key: HDFS-4056
>                 URL: https://issues.apache.org/jira/browse/HDFS-4056
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-4056.patch
>
>
> To support the ability to use tokens regardless of whether kerberos is enabled, the NN's secret manager should always be started.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira