hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4036) FSDirectory.unprotectedAddFile(..) should not throw UnresolvedLinkException
Date Mon, 15 Oct 2012 17:06:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476262#comment-13476262

Eli Collins commented on HDFS-4036:

bq. Eli, I think the reason is that this method is "unprotected".

Nicholas, but why is it unprotected? In What cases should we unconditionally swallow an IOE?
Shouldn't we at least log a debug? 
> FSDirectory.unprotectedAddFile(..) should not throw UnresolvedLinkException
> ---------------------------------------------------------------------------
>                 Key: HDFS-4036
>                 URL: https://issues.apache.org/jira/browse/HDFS-4036
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 3.0.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Jing Zhao
>             Fix For: 2.0.3-alpha
>         Attachments: HDFS-4036-trunk.001.patch
> The code in FSDirectory.unprotectedAddFile(..) does not throw UnresolvedLinkException,
we should remove "throws UnresolvedLinkException" from the declaration.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message