hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4034) Remove redundant null checks
Date Thu, 11 Oct 2012 00:01:03 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Eli Collins updated HDFS-4034:

    Attachment: hdfs-4034.txt

Patch attached. Fixes the redundant null checks, also fixes a place where we're not checking
null that it gets confused by due to a call to terminate (which may System.exit).
> Remove redundant null checks
> ----------------------------
>                 Key: HDFS-4034
>                 URL: https://issues.apache.org/jira/browse/HDFS-4034
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-4034.txt
> Findbugs 2 catches a number of places where we're checking for null in cases where the
value will never be null.
> We might need to wait until we switch to findbugs 2 to commit this as the current findbugs
may not be so smart.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message