[ https://issues.apache.org/jira/browse/HDFS-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Collins updated HDFS-4031:
------------------------------
Summary: Update findbugsExcludeFile.xml to include findbugs 2 exclusions (was: Update
findbugsExcludeFile.xml to reflect )
> Update findbugsExcludeFile.xml to include findbugs 2 exclusions
> ---------------------------------------------------------------
>
> Key: HDFS-4031
> URL: https://issues.apache.org/jira/browse/HDFS-4031
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-4031.txt
>
>
> Findbugs 2 warns about some volatile increments (VO_VOLATILE_INCREMENT) that unlike HDFS-4029
and HDFS-4030 are less problematic:
> - numFailedVolumes is only incremented in one thread and that access is synchronized
> - pendingReceivedRequests in BPServiceActor is clearly synchronized
> It would be reasonable to make these Atomics as well but I think they're uses are clearly
correct so figured for these the warning was more obviously bogus and so could be ignored.
> There's also a SE_BAD_FIELD_INNER_CLASS warning (LocalDatanodeInfo's anonymous class
is serializable but it is not) in BPServiceActor is OK to ignore since we don't serialize
LocalDatanodeInfo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|