hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4106) BPServiceActor#lastHeartbeat, lastBlockReport and lastDeletedReport should be declared as volatile
Date Mon, 29 Oct 2012 13:04:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485997#comment-13485997
] 

Hudson commented on HDFS-4106:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1210 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1210/])
    HDFS-4106. BPServiceActor#lastHeartbeat, lastBlockReport and lastDeletedReport should
be volatile. Contributed by Jing Zhao. (Revision 1403075)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1403075
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java

                
> BPServiceActor#lastHeartbeat, lastBlockReport and lastDeletedReport should be declared
as volatile
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4106
>                 URL: https://issues.apache.org/jira/browse/HDFS-4106
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node, test
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HDFS-4106-trunk.001.patch, HDFS-4106-trunk.002.patch
>
>
> All these variables may be assigned/read by a testing thread (through BPServiceActor#triggerXXX)
while also assigned/read by the actor thread. Thus they should be declared as volatile to
make sure the "happens-before" consistency.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message