hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3224) Bug in check for DN re-registration with different storage ID
Date Thu, 11 Oct 2012 01:55:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473776#comment-13473776
] 

Jason Lowe commented on HDFS-3224:
----------------------------------

Manually ran test-patch.sh on the branch-0.23 patch:

{noformat}
-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version ) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestDatanodeBlockScanner

    +1 contrib tests.  The patch passed contrib unit tests.
{noformat}

The TestDatanodeBlockScanner failure appears to be unrelated, and it passed when I ran the
test again.  I also manually tested a re-imaged datanode rejoining the cluster and the namenode
correctly recognized it as a previously registered datanode after this patch.
                
> Bug in check for DN re-registration with different storage ID
> -------------------------------------------------------------
>
>                 Key: HDFS-3224
>                 URL: https://issues.apache.org/jira/browse/HDFS-3224
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eli Collins
>            Assignee: Jason Lowe
>            Priority: Minor
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-3224-branch0.23.patch, HDFS-3224.patch, HDFS-3224.patch, HDFS-3224.patch,
HDFS-3224.patch
>
>
> DatanodeManager#registerDatanode checks the host to node map using an IP:port key, however
the map is keyed on IP, so this check will always fail. It's performing the check to determine
if a DN with the same IP and storage ID has already registered, and if so to remove this DN
from the map and indicate that eg it's no longer hosting these blocks. This bug has been here
forever.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message