hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4097) provide CLI support for create/delete/list snapshots
Date Tue, 23 Oct 2012 04:53:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482111#comment-13482111
] 

Suresh Srinivas commented on HDFS-4097:
---------------------------------------

Comments:
# FileSystem.java - "doesn't support listSnapshot" - change listSnapshot to listSnapshots
# SnapshotInfo.java - this class cannot be private and evolving since it is exposed in FileSystem.java
a class that has audience public.
# SnapshotCommand.java
#* there are couple of places your using "_" instead of "-" in registerCommand()
#* Instead of printing "Snap Name"  you could just print "Name"
#* I will format the printing based on "ls" command out put. At least the snapshot name should
be printed in the end (given its length could vary). What format are you printing date in?
Can you post an example output?
# javadoc {{@see ClientProtocol#deleteSnap(String snapshotName, String snapshotRoot)}} - method
should be deleteSnapshot
# When you are overriding, no need to add javadoc to the method if you plan on inheriting
changes from the super class. So javadoc for DistributedFileSystem methods you have added
can be deleted.
# FSNamsystem.java
#* Why are you adding @VisibleForTesting for snapshot related methods in FSNamesystem. Also
please proper javadoc to the methods.
#* Why no just return new SnapshotInfo[0] from #listSnapshots()

                
> provide CLI support for create/delete/list snapshots
> ----------------------------------------------------
>
>                 Key: HDFS-4097
>                 URL: https://issues.apache.org/jira/browse/HDFS-4097
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs client, name-node
>    Affects Versions: Snapshot (HDFS-2802)
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>              Labels: needs-test
>         Attachments: HDFS-4097.patch, HDFS-4097.patch
>
>
> provide CLI support for create/delete/list snapshots

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message