hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Isaacson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers
Date Mon, 29 Oct 2012 22:19:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486425#comment-13486425
] 

Andy Isaacson commented on HDFS-3643:
-------------------------------------

bq. Wouldn't it be a string which comes from the signature? eg something like "Ljava/lang/String;"
or "J"?

No, it's one of the constants JINT, JLONG, etc.  Valid values are ASCII alphanumeric, but
in the error case it could be an arbitrary {{char}} so printing it with {{%c}} is unlikely
to be helpful.  I suppose casting to {{(unsigned char)returnType}} helps if char is signed
and <0.  I'll do that and upload a new patch.
                
> hdfsJniHelper.c unchecked string pointers
> -----------------------------------------
>
>                 Key: HDFS-3643
>                 URL: https://issues.apache.org/jira/browse/HDFS-3643
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>         Attachments: hdfs-3643-1.txt, hdfs3643-2.txt, hdfs3643.txt
>
>
> {code}
>     str = methSignature;
>     while (*str != ')') str++;
>     str++;
>     returnType = *str;
> {code}
> This loop needs to check for {{'\0'}}. Also the following {{if/else if/else if}} cascade
doesn't handle unexpected values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message