hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4072) When deleting a file, it would be better to also remove corresponding block records from BlockManager#pendingReplications
Date Thu, 18 Oct 2012 04:12:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478642#comment-13478642
] 

Suresh Srinivas commented on HDFS-4072:
---------------------------------------

bq. Adding pendingReplications.remove(block) to removeBlock means we're just decrementing
the replica count by 1 right? 
Good catch.

bq.  Seems like we should add this call to removeStoredBlock instead
I do not think it works that way. Number of replicas reported as deleted and the number of
pending replications are different. I think we should introduce a method to remove the pending
replication given a block, instead of decrementing a count.

I think the existing names are poorly named as well. Methods should be renamed:
# add() to increment()
# remove() to decrement()
# New method remove that removes the block from the map
                
> When deleting a file, it would be better to also remove corresponding block records from
BlockManager#pendingReplications
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4072
>                 URL: https://issues.apache.org/jira/browse/HDFS-4072
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4072.trunk.001.patch, HDFS-4072.trunk.002.patch, TestPendingAndDelete.java
>
>
> Currently when deleting a file, blockManager does not remove records that are corresponding
to the file's blocks from pendingRelications. These records can only be removed after timeout
(5~10 min).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message