hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4072) When deleting a file, it would be better to also remove corresponding block records from BlockManager#pendingReplications
Date Wed, 17 Oct 2012 21:58:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478435#comment-13478435
] 

Suresh Srinivas commented on HDFS-4072:
---------------------------------------

Patch looks good. Can you combine the test and the fix?

In the test please remove unnecessary cast to DistributedFileSystem in setup() method.

Unrelated to this patch, since you are in that part of the code:
# Since you are in that part of the code can you remove unnecessary exception declared as
thrown from BlockManager#createBlockTokenSecretManager.
# BlockManager#chooseTarget javadoc has incorrect @see to BlockPlacementPolicy method
# BlockManager#queueReportedBlock has unnecessary { } around @see block
# BlockManager#addStorageBlockImmediately() @link should have # preceding addStorageBlock().
Similar change for method countLiveNodes().
                
> When deleting a file, it would be better to also remove corresponding block records from
BlockManager#pendingReplications
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4072
>                 URL: https://issues.apache.org/jira/browse/HDFS-4072
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4072.trunk.001.patch, TestPendingAndDelete.java
>
>
> Currently when deleting a file, blockManager does not remove records that are corresponding
to the file's blocks from pendingRelications. These records can only be removed after timeout
(5~10 min).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message