hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4106) BPServiceActor#lastHeartbeat, lastBlockReport and lastDeletedReport should be declared as volatile
Date Tue, 23 Oct 2012 20:17:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482635#comment-13482635
] 

Brandon Li commented on HDFS-4106:
----------------------------------

Volatile variable brings performance issues in multithreaded environment. If the testing thread
is only concern, can we fix the tests instead?
                
> BPServiceActor#lastHeartbeat, lastBlockReport and lastDeletedReport should be declared
as volatile
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4106
>                 URL: https://issues.apache.org/jira/browse/HDFS-4106
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4106-trunk.001.patch
>
>
> All these variables may be assigned/read by a testing thread (through BPServiceActor#triggerXXX)
while also assigned/read by the actor thread. Thus they should be declared as volatile to
make sure the "happens-before" consistency.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message