hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers
Date Mon, 29 Oct 2012 21:48:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486399#comment-13486399
] 

Todd Lipcon commented on HDFS-3643:
-----------------------------------

{code}
+    else {
+        jthr = newRuntimeError(env, "invokeMethod: invalid return type 0x%02x",
+                               returnType);
+    }
{code}

Why is returnType being printed in hex here? Wouldn't it be a string which comes from the
signature? eg something like "Ljava/lang/String;" or "J"?
                
> hdfsJniHelper.c unchecked string pointers
> -----------------------------------------
>
>                 Key: HDFS-3643
>                 URL: https://issues.apache.org/jira/browse/HDFS-3643
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>         Attachments: hdfs-3643-1.txt, hdfs3643.txt
>
>
> {code}
>     str = methSignature;
>     while (*str != ')') str++;
>     str++;
>     returnType = *str;
> {code}
> This loop needs to check for {{'\0'}}. Also the following {{if/else if/else if}} cascade
doesn't handle unexpected values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message