hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4052) FSNameSystem#invalidateWorkForOneNode and FSNameSystem#computeReplicationWorkForBlock in branch-1 should print debug information outside of the namesystem lock
Date Tue, 16 Oct 2012 02:35:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476672#comment-13476672
] 

Hadoop QA commented on HDFS-4052:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12549176/HDFS-4052.trunk.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3339//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3339//console

This message is automatically generated.
                
> FSNameSystem#invalidateWorkForOneNode and FSNameSystem#computeReplicationWorkForBlock
in branch-1 should print debug information outside of the namesystem lock
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4052
>                 URL: https://issues.apache.org/jira/browse/HDFS-4052
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 1.2.0, 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4052.b1.001.patch, HDFS-4052.trunk.001.patch
>
>
> Currently in branch-1, both FSNameSystem#invalidateWorkForOneNode and FSNameSystem#computeReplicationWorkForBlock
print debug information (which can be a long msg generated by traversing a list/array) without
releasing the FSNameSystem lock. It would be better to move them outside of the namesystem
lock.
> This may also apply to FSNameSystem#invalidateWorkForOneNode in trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message