hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4029) GenerationStamp should use an AtomicLong
Date Thu, 11 Oct 2012 03:13:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473800#comment-13473800
] 

Hadoop QA commented on HDFS-4029:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548655/hdfs-4029.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3307//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3307//console

This message is automatically generated.
                
> GenerationStamp should use an AtomicLong 
> -----------------------------------------
>
>                 Key: HDFS-4029
>                 URL: https://issues.apache.org/jira/browse/HDFS-4029
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-4029.txt
>
>
> GenerationStamp#genstamp is a volatile long. Incrementing volatiles is not thread safe,
which is currently not an issue because the only increment is done in nextStamp which is synchronized
(theoretically setStamp could race with nextStamp though that wouldn't happen given the current
code). It would be cleaner to use an AtomicLong so that genstamp itself is atomic and we don't
have to synchronize the various accesses to it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message