hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4007) Rehabilitate bit-rotted unit tests under hadoop-hdfs-project/hadoop-hdfs/src/test/unit/
Date Sat, 06 Oct 2012 14:09:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471018#comment-13471018
] 

Hadoop QA commented on HDFS-4007:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548043/HDFS-4007.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestDistributedFileSystem

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3286//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3286//console

This message is automatically generated.
                
> Rehabilitate bit-rotted unit tests under hadoop-hdfs-project/hadoop-hdfs/src/test/unit/
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-4007
>                 URL: https://issues.apache.org/jira/browse/HDFS-4007
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.0.0-alpha
>
>         Attachments: HDFS-4007.001.patch
>
>
> There are a bunch of unit tests under hadoop-hdfs-project/hadoop-hdfs/src/test/unit/
that did not get Mavenized, and have bit-rotted over time.
> It looks like TestDataDirs and TestINodeFile should get compiled again as part of the
build.  There is already another copy of TestGetImageServlet in the source tree, so that should
get deleted.  Similarly TestNNLeaseRecovery has bit-rotted too much, and should be deleted--
given that we already have some other lease recovery tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message