hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3224) Bug in check for DN re-registration with different storage ID
Date Tue, 09 Oct 2012 14:31:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472424#comment-13472424
] 

Suresh Srinivas commented on HDFS-3224:
---------------------------------------

bq. I'm a bit squeamish that Host2NodesMap.getDatanodeByXferAddr(String, int) requires the
caller to have the intimate knowledge of how Host2NodesMap#add(DatanodeDescriptor) keyed the
node in the map. It's creating a landmine if someone doesn't update both the add the caller's
lookups in unison - and we're right back to this bug.

Daryn I do not understand the part "update both the add the caller's lookups". We could continue
that discussion and if it warrants we could create a separate jira to address your concerns.


+1. This patch looks good to me.


                
> Bug in check for DN re-registration with different storage ID
> -------------------------------------------------------------
>
>                 Key: HDFS-3224
>                 URL: https://issues.apache.org/jira/browse/HDFS-3224
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eli Collins
>            Assignee: Jason Lowe
>            Priority: Minor
>         Attachments: HDFS-3224.patch, HDFS-3224.patch
>
>
> DatanodeManager#registerDatanode checks the host to node map using an IP:port key, however
the map is keyed on IP, so this check will always fail. It's performing the check to determine
if a DN with the same IP and storage ID has already registered, and if so to remove this DN
from the map and indicate that eg it's no longer hosting these blocks. This bug has been here
forever.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message