hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4018) TestDataNodeMultipleRegistrations#testMiniDFSClusterWithMultipleNN is missing some cluster cleanup
Date Mon, 08 Oct 2012 17:56:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471699#comment-13471699
] 

Aaron T. Myers commented on HDFS-4018:
--------------------------------------

bq. Wrt #2, I understand why we check cluster for null, but per my above comment cluster could
never be null here right?

Ah, touche. Usually when I do this I declare the cluster outside of the try block, but initialize
it within, in which case the null check is desirable. You're right that in this case it doesn't
matter.

+1 pending Jenkins.
                
> TestDataNodeMultipleRegistrations#testMiniDFSClusterWithMultipleNN is missing some cluster
cleanup
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4018
>                 URL: https://issues.apache.org/jira/browse/HDFS-4018
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-4018.txt, hdfs-4018.txt
>
>
> TestDataNodeMultipleRegistrations#testMiniDFSClusterWithMultipleNN does not unconditionally
shutdown the cluster if a call to addNameNode fails, so if one of these calls fails other
tests may failed due to the NN directory already being locked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message