hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4031) Update findbugsExcludeFile.xml to include findbugs 2 exclusions
Date Thu, 11 Oct 2012 01:43:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473772#comment-13473772
] 

Hadoop QA commented on HDFS-4031:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548659/hdfs-4031.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3303//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3303//console

This message is automatically generated.
                
> Update findbugsExcludeFile.xml to include findbugs 2 exclusions
> ---------------------------------------------------------------
>
>                 Key: HDFS-4031
>                 URL: https://issues.apache.org/jira/browse/HDFS-4031
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-4031.txt
>
>
> Findbugs 2 warns about some volatile increments (VO_VOLATILE_INCREMENT) that unlike HDFS-4029
and HDFS-4030 are less problematic:
> - numFailedVolumes is only incremented in one thread and that access is synchronized
> - pendingReceivedRequests in BPServiceActor is clearly synchronized
> It would be reasonable to make these Atomics as well but I think they're uses are clearly
correct so figured for these the warning was more obviously bogus and so could be ignored.
> There's also a SE_BAD_FIELD_INNER_CLASS warning (LocalDatanodeInfo's anonymous class
is serializable but it is not) in BPServiceActor is OK to ignore since we don't serialize
LocalDatanodeInfo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message