hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4057) NameNode.namesystem should be private. Use getNamesystem() instead.
Date Wed, 17 Oct 2012 22:56:03 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478476#comment-13478476

Brandon Li commented on HDFS-4057:

test-patch result:
-1 overall.  
    +1 @author.  The patch does not contain any @author tags.
    +1 tests included.  The patch appears to include 54 new or modified tests.
    +1 javadoc.  The javadoc tool did not generate any warning messages.
    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
    -1 findbugs.  The patch appears to introduce 197 new Findbugs (version 2.0.0) warnings.

The findbug warnings were not introduced by this patch.
> NameNode.namesystem should be private. Use getNamesystem() instead.
> -------------------------------------------------------------------
>                 Key: HDFS-4057
>                 URL: https://issues.apache.org/jira/browse/HDFS-4057
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 1.2.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-4057.branch-1.patch, HDFS-4057.branch-1.patch
> NameNode.namesystem should be private. One should use NameNode.getNamesystem() to get
it instead.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message