Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 4 Sep 2012 16:55:07 +1100 (NCT)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <672902798.31584.1346738107517.JavaMail.jiratomcat@arcas>
In-Reply-To: <1311576750.26475.1346484967797.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (HDFS-3884) QJM: Journal format() should reset
 cached values
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-3884:
------------------------------

    Attachment: hdfs-3884.txt

Before committing, realized this introduced a findbugs error. Needed to add 'synchronized' keyword to avoid 'inconsistent synchronization' on these fields.
                
> QJM: Journal format() should reset cached values
> ------------------------------------------------
>
>                 Key: HDFS-3884
>                 URL: https://issues.apache.org/jira/browse/HDFS-3884
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: QuorumJournalManager (HDFS-3077)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: QuorumJournalManager (HDFS-3077)
>
>         Attachments: hdfs-3884.txt, hdfs-3884.txt
>
>
> Simple bug in the JournalNode: it caches certain values (eg accepted epoch) in memory, and the cached values aren't reset when the journal is formatted. So, after a format, further calls to the same Journal will see the old value for accepted epoch, writer epoch, etc, preventing the journal from being re-used until the JN is restarted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira