Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 6 Sep 2012 01:02:53 +1100 (NCT)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <220493828.39004.1346853773409.JavaMail.jiratomcat@arcas>
In-Reply-To: <532937195.35279.1346797147708.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-3888) BlockPlacementPolicyDefault code
 cleanup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448752#comment-13448752 ] 

Hudson commented on HDFS-3888:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1187 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1187/])
    HDFS-3888. Clean up BlockPlacementPolicyDefault.  Contributed by Jing Zhao (Revision 1380939)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1380939
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java

                
> BlockPlacementPolicyDefault code cleanup
> ----------------------------------------
>
>                 Key: HDFS-3888
>                 URL: https://issues.apache.org/jira/browse/HDFS-3888
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3888.patch, HDFS-3888.patch
>
>
> BlockPlacementPolicyDefault#LOG should be removed as it hides LOG from the base class BlockPlacementPolicy. Also, in BlockPlacementPolicyDefault#chooseTarget method, the logic computing the maxTargetPerLoc can be made a separate method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira