Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6634ADFEA for ; Thu, 6 Sep 2012 16:43:08 +0000 (UTC) Received: (qmail 66061 invoked by uid 500); 6 Sep 2012 16:43:08 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 66018 invoked by uid 500); 6 Sep 2012 16:43:08 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 65957 invoked by uid 99); 6 Sep 2012 16:43:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2012 16:43:08 +0000 Date: Fri, 7 Sep 2012 03:43:08 +1100 (NCT) From: "Uma Maheswara Rao G (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <2104750761.45138.1346949788102.JavaMail.jiratomcat@arcas> In-Reply-To: <1609476602.19285.1345132298095.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449793#comment-13449793 ] Uma Maheswara Rao G commented on HDFS-3809: ------------------------------------------- one small nit: {code} private final NamespaceInfo nsInfo; {code} Why do we need this as field variable? we just used it in ctor only right? > Make BKJM use protobufs for all serialization with ZK > ----------------------------------------------------- > > Key: HDFS-3809 > URL: https://issues.apache.org/jira/browse/HDFS-3809 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Affects Versions: 2.0.0-alpha, 3.0.0 > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Attachments: HDFS-3809.diff, HDFS-3809.diff, HDFS-3809.diff > > > HDFS uses protobufs for serialization in many places. Protobufs allow fields to be added without breaking bc or requiring new parsing code to be written. For this reason, we should use them in BKJM also. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira