hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3916) libwebhdfs (C client) code cleanups
Date Tue, 11 Sep 2012 01:45:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452643#comment-13452643

Colin Patrick McCabe commented on HDFS-3916:

note: I think the exception-handling mechanism needs more work.  {{exception.c}} expects exception
names in the format {{java/io/FileNotFoundException}}, but the webhdfs JSON data returns them
as {{java.io.FileNotFoundException}}.  We probably need to replace the dots with slashes.
 This is in addition to the other changes.  Will post a patch shortly.

note2: I think we should require all URIs for libwebhdfs to be in the form {{webhdfs://nn:port}}
(port optional).  We definitely don't support {{hdfs://}}, {{file://}}, or any of the other
protocol types, so let's make that clear.
> libwebhdfs (C client) code cleanups
> -----------------------------------
>                 Key: HDFS-3916
>                 URL: https://issues.apache.org/jira/browse/HDFS-3916
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: 0002-fix.patch
> Code cleanups in libwebhdfs.
> * don't duplicate exception.c, exception.h, expect.h, jni_helper.c.  We have one copy
of these files; we don't need 2.
> * remember to set errno in all public library functions (this is part of the API)
> * fix undefined symbols (if a function is not implemented, it should return ENOTSUP,
but still exist)
> * don't expose private data structures in the (end-user visible) public headers
> * can't re-use hdfsBuilder as hdfsFS, because the strings in hdfsBuilder are not dynamically

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message