hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3910) DFSTestUtil#waitReplication should timeout
Date Tue, 11 Sep 2012 19:52:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453339#comment-13453339
] 

Aaron T. Myers commented on HDFS-3910:
--------------------------------------

Patch looks pretty good to me. Two little nits:

# It would be good to include the exception stack trace here:
{code}
-      } catch (IOException e) {
-        LOG.warn("Shouldn't happen", e);
+      } catch (Exception e) {
+        Assert.fail("Failed to start BlockChecker");
{code}
# In a few places you indent the "{{throws}}" declaration of methods that continue onto the
next line 2 spaces instead of 4, e.g. in TestFileInputFormat and1 UtilsForTests.

+1 once these are addressed.
                
> DFSTestUtil#waitReplication should timeout
> ------------------------------------------
>
>                 Key: HDFS-3910
>                 URL: https://issues.apache.org/jira/browse/HDFS-3910
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3910.txt, hdfs-3910.txt
>
>
> DFSTestUtil#waitReplication never times out so test execution fails only when the mvn
test executor times out. This leaves a stray test process around, an example is HDFS-3902.
Let's make waitReplication do something like bail after it has checked block locations 10
times for one file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message