hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3975) Add a test for umask in webhdfs
Date Wed, 26 Sep 2012 16:53:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463949#comment-13463949
] 

Colin Patrick McCabe commented on HDFS-3975:
--------------------------------------------

bq. Are you sure that the test is not already covered by TestWebHdfsFileSystemContract and
TestFSMainOperationsWebHdfs?

That's a good question.  I can see that there's a few places where we test permissions-- for
example in {{TestWebHdfsFileSystemContract#testResponseCode}} we create a directory and verify
that it got permissions of {{0755}}.  This implicitly creates the directory with {{0777}},
and since the default umask is {{022}}, it gets permissions {{0755}}.

I'm not sure if that really qualifies as a test of umask though-- we never explicitly set
umask to something other than the default.  In fact we never explicitly specify a non-default
permission mode when creating a directory or file in the existing webhdfs tests, so I would
say that existing coverage not very complete.

What do you think?  Would it make more sense to add this new test in TestWebHdfsFileSystemContract?
                
> Add a test for umask in webhdfs
> -------------------------------
>
>                 Key: HDFS-3975
>                 URL: https://issues.apache.org/jira/browse/HDFS-3975
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3975.001.patch
>
>
> Add a unit test to make sure {{umask}} is working correctly in webhdfs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message