hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2793) Add an admin command to trigger an edit log roll
Date Tue, 04 Sep 2012 21:28:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448076#comment-13448076

Aaron T. Myers commented on HDFS-2793:

Patch looks pretty good to me. Just a few little comments:

# I don't understand why this "if(...)" is necessary:
if (isFromClient) {
It's certainly the case that arbitrary clients should be super users, but when would a non-super
user node be calling this method? I think it should be safe to always check for super user
# Should the rollEdits RPC be marked {{@Idempotent}}? I can't think of a case when calling
it twice would be problematic.
> Add an admin command to trigger an edit log roll
> ------------------------------------------------
>                 Key: HDFS-2793
>                 URL: https://issues.apache.org/jira/browse/HDFS-2793
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2793.txt
> This seems like it would also be helpful outside of the context of HA, but especially
so given that the standby can currently only read finalized log segments.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message