hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3911) Tests setLevel(Level.OFF) should be Level.ERROR
Date Mon, 10 Sep 2012 20:32:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452419#comment-13452419
] 

Eli Collins commented on HDFS-3911:
-----------------------------------

good call

+1 pending jenkins
                
> Tests setLevel(Level.OFF) should be Level.ERROR
> -----------------------------------------------
>
>                 Key: HDFS-3911
>                 URL: https://issues.apache.org/jira/browse/HDFS-3911
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.1-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>            Priority: Minor
>         Attachments: hdfs-3911.txt
>
>
> Multiple tests have code like
> {code}
> ((Log4JLogger)LogFactory.getLog(FSNamesystem.class)).getLogger().setLevel(Level.OFF);
> {code}
> Completely disabling logs from given classes with {{Level.OFF}} is a bad idea and makes
debugging other test failures, especially intermittent test failures like HDFS-3664, difficult.
 Instead the code should use {{Level.ERROR}} to reduce verbosity.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message